Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move matrix config to info.json, part 3 #19991

Merged
merged 7 commits into from
Mar 10, 2023
Merged

Move matrix config to info.json, part 3 #19991

merged 7 commits into from
Mar 10, 2023

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Mar 2, 2023

Description

#19987

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team March 2, 2023 13:24
@fauxpark fauxpark mentioned this pull request Mar 3, 2023
Merged
14 tasks
@drashna drashna requested a review from a team March 10, 2023 07:30
@fauxpark @tzarc
Update keyboards/takashiski/namecard2x4/rev1/info.json
35825a8 
Co-authored-by: Nick Brassel <nick@tzarc.org>
@tzarc tzarc merged commit ace372d into qmk:develop Mar 10, 2023
@fauxpark fauxpark deleted the matrix-pins-data-driven-3 branch March 10, 2023 13:35
freznel10 pushed a commit to freznel10/qmk_firmware that referenced this pull request May 17, 2023
@fauxpark @tzarc @freznel10
Move matrix config to info.json, part 3 (qmk#19991)
0f7bf80 
Co-authored-by: Nick Brassel <nick@tzarc.org>
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@fauxpark @tzarc @coquizen
Move matrix config to info.json, part 3 (qmk#19991)
0d556ef 
Co-authored-by: Nick Brassel <nick@tzarc.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @tzarc